[Mono-dev] [PATCH] Validation for <xsl:output> attributes.
atsushi at ximian.com
Fri Dec 23 14:30:41 EST 2005
Gert Driesen wrote:
> Comments inline
>> -----Original Message-----
>> From: mono-devel-list-bounces at lists.ximian.com
>> [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf
>> Of Atsushi Eno
>> Sent: dinsdag 20 december 2005 6:26
>> To: Gert Driesen
>> Cc: mono-devel-list at ximian.com
>> Subject: Re: [Mono-dev] [PATCH] Validation for <xsl:output>
>>> The attached patch implements validation for <xsl:output>
>> attributes, and
>>> adds unit tests.
>>> I've also added some unit tests for XsltCompileException
>> and XslException.
>>> Some test are marked NotWorking, due to bugs in Mono (for
>> which I'll report
>>> bug reports later).
>> Some comments:
>> - You can try Mainsoft XSLT standalone tests. Go to
>> Test/System.Xml.Xsl/standalone and run "make run-test", then
>> you can find some regressions.
>> - Your code that checks attributes is good.
>> - "indent" in xsl:output is "yes" by default when the output
>> method is "html", unlike when it is "xml" ("no"). That's why
>> we have string value instead of boolean in XslOutput class.
> I now use an enum for this internally, which allows us to continue exposing
> Intend as a bool.
Please checkin this change as well. Some of Mainsoft XSLT tests
started to fail after r54780.
More information about the Mono-devel-list