[Mono-devel-list] [PATCH] Fix null reference exceptions in System.Data.DataView
haisenko at webport.de
Wed Jul 6 09:18:19 EDT 2005
On Wednesday 06 July 2005 14:03, Konstantin Triger wrote:
> Hello Marc,
> My view that a problem is deeper: probably we run into a situation where
> the DataView is not functional when it should be. Replacing the
> assignment of rowCache to an empty array will prevent throwing an
> exception, but will not solve the logical problem.
> Please open a bugzilla bug with a test case and a patch attached.
> Konstantin Triger
I don't think there's a logical problem in DataView.cs, the code seems quite
fine to me. Of course a few more bound checks here and there wouldn't hurt,
but they only miss in cases where an exception due to an index out bounds is
expected anyways. And it works alright for us when rowCache isn't null, and
the code is written assuming rowCache will never be null (we it was
initialized with null, I don't know).
But if you really think it's necessary and that the patch doesn't suffice I
can of course file a bug report...
Webport IT-Services GmbH
mailto: haisenko at webport.de
More information about the Mono-devel-list