[Mono-devel-list] [PATCH] Reworked unified Locale classes
bmaurer at ximian.com
Sat Jun 11 13:08:26 EDT 2005
On Sat, 2005-06-11 at 19:04 +0200, Kornél Pál wrote:
> > I think you forgot to svn add the new file.
> You are right I forgot it.:) The diff file was simply too large to notice
> the missing file.:) I attached a new diff file.
> > I think a good place to start is to check in the common Locale.cs code
> > (but *without* changing the contents of the Locale.cs file: IE, just
> > remove all the copy and paste crap). This will make your patches much
> > smaller. Anybody have an objection to this?
> Originally I just wanted to replace the current Locale.cs that does
> absolutely nothing with a proper implementation that supports multuple
> languages and behaves like gettext () so it returns the message passed to
> GetText for invariant culture.
> Then you proposed to use a single copy in all of the assemblies instead of
> multiple copies. I have done it.
> But now you say not to use my version simply copy the current version to a
> new location. This means you drop my patch. But as the current version does
> nothing I think it's no use to do this.
> Note that I have removed the unnecessary redundant Locale.cs files using svn
> delete and this resulted in the - (minus) entries for each file in the diff
As I mentioned to you on private email, there is a very big point to
doing this. By removing the duplicated code today, your patches tomorrow
will be easier for us to read.
I'm not suggesting that the Locale.cs today should be what we use
forever. I am suggesting: lets first get one Locale.cs which is the same
as we have today, and *then* start patching.
More information about the Mono-devel-list