[Mono-dev] Ask for patch review
sebastien.pouliot at gmail.com
Tue Dec 12 10:30:07 EST 2006
On Tue, 2006-12-12 at 12:57 +0100, "Andrés G. Aragoneses [ knocte ]"
> Miguel de Icaza escribió:
> > Hello,
> >> Can someone review (and commit) the small patch proposed on bug 80225?
> >> ( http://bugzilla.ximian.com/show_bug.cgi?id=80225 )
> > Could you provide NUnit tests cases for the behavior described?
> Ok, I will attach some (based on the testcase I filed)
> the new patch gets approved.
The tests are required in order to approve the patch. The current
behavior may be bad (in some/most cases and/or wrt fx 2.0) but some
applications, including Mono itself, can depend on it.
The tests should include
- using an assembly name with a public key
- using an assembly name without a public key
- using an assembly name from a dynamic assembly (created using SRE)
and should be tested against both Fx 1.1 and 2.0.
The source code of mscorlib.dll and System.dll should also be checked to
ensure nothing depends on a null check for this value.
Sebastien Pouliot <sebastien at ximian.com>
More information about the Mono-devel-list