[Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter
atsushi at ximian.com
Thu Jan 5 04:15:41 EST 2006
Gert Driesen wrote:
>> -----Original Message-----
>> From: Atsushi Eno [mailto:atsushi at ximian.com]
>> Sent: Thursday, January 5, 2006 04:53 AM
>> To: 'Gert Driesen'
>> Cc: mono-devel-list at ximian.com
>> Subject: Re: [Mono-dev] [PATCH] Minor fixes for XmlElement & XmlTextWriter
>> Hi Gert,
>> It would be nicer if you avoid application/octet-stream to post
> Must be my "favorite" mail client (Outlook) then. I'll see if I can change that.
Mhm, Outlook. It might not be possible to change it (I asked some
other guys but they just cannot, by its design).
>> In XmlElementTests.cs, I think those additional lines could be split
>> to another method and be shared (since null seems equivalent as
>> String.Empty in 2.0).
> Ok, I'll look into it.
>> As for your code in general, please conform to coding guidelines
>> e.g. switch-case indentation and having extra brace for one liner
>> if-s (especially considering that you often do code reformatting;
>> doing it ignoring coding guidelines won't be welcomed).
> It's sometimes hard to kick old habits, but I'll try ;-)
It's always painful, yes ;-)
>> If you agree with above please commit the patch after fixing them
>> (no need to excuse as long as changes are related only to above).
> Ok, I'll probably send an updated patch to you or the list for approval, just to avoid getting you on my back again ;-)
Haha, no worries, please just commit a fix. If any problem I'll hit
you but I don't think it is likely to happen. I trust you.
More information about the Mono-devel-list