[Mono-dev] System.Web.UI/HtmlTextWriter.cs issue
Gonzalo Paniagua Javier
gonzalo at ximian.com
Fri Jan 13 13:19:44 EST 2006
On Thu, 2006-01-12 at 14:09 -0500, Ben Maurer wrote:
> > In this case the "return chk();" will be added to the onclick event in
> > addition to the validation code there.
> 1) you should not use .ToLower to do case insensitive compares, but
> String.Compare. Also, you must use the invariant culture.
> 2) Why would attrName (or the others) ever be null or empty
> 3) Is onclick the *only* attribute that this happens to?
> 4) Some of the microsoft code seems to add semicolons for you at the end
> of js statements if you don't. Does this one do that too
> 5) No patch should ever be made without test cases.
After Ben's Five Commandments, I have this bug here that will probably
be fixed with this patch:
More information about the Mono-devel-list