[Mono-dev] System.Web.UI/HtmlTextWriter.cs issue
Gonzalo Paniagua Javier
gonzalo at ximian.com
Thu Jan 19 19:34:37 EST 2006
On Sun, 2006-01-15 at 07:35 -0800, Konstantin Triger wrote:
> Attached 2 patches, which, I believe, handle the issues better.
> 1. HtmlTextWriter.patch: addresses 1, 2 and 5.
> 2. button.patch:
> Point 3: My better understanding is that we must not delete user
> data. Thus we may only append our logic.
> Point 4: not in this particular case.
> Point 5: Unfortunately I do not know how to create a unit test
> for this scenario, as it depends on browser capabilities and some Page
> properties. Is there a way to control this?
The patch for HtmlTextWriter + test is ok to commit.
As for the button one... Can you do some manual tests to check which of
the user code and the system.web generated code go first in the onclick
attribute? As your patch is now, if there's no semicolon at the end, we
might get in trouble.
More information about the Mono-devel-list