[Mono-dev] System.IO.UnmanagedMemoryStream class implementation
sridharkulkarni at msn.com
Tue Jul 18 06:47:24 EDT 2006
Thanks for your review comments. I have incorporated them in this. I am
writing NUnit test cases for this class and will submit as soon as I am done
with that. Any review comments please let me know.
>From: Miguel de Icaza <miguel at ximian.com>
>To: Sridhar Kulkarni <sridharkulkarni at msn.com>
>CC: mono-devel-list at lists.ximian.com, mono-devel-list at ximian.com
>Subject: Re: System.IO.UnmanagedMemoryStream class implementation
>Date: Mon, 17 Jul 2006 11:16:40 -0400
> Thanks for your contribution to the UnmanagedMemoryStream.
> Could you change your implementation to not use "canread" and
>"canwrite", but instead to use a field of type FileAccess and check
>against that value instead?
> Also, identifiers should follow the conventions, so they should use
>underscores, like "current_pointer" instead of currentpointer.
> The "Position" property should probably check against the boundary
>passed in "capacity" in the constructor (if this is not a MemoryStream
>buffer). There is also a TODO item in the source code that must be
> Ideally, it would be great if you could write some NUnit tests
>cases as well to go along this implementation.
Who will win Bollywoods most coveted IIFA awards? You decide! Cast your
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the Mono-devel-list