[Mono-dev] [SPAM] [PATCH] Simplifying/optimizing CodeGenerator.cs
js at hotfeet.ch
Mon Jan 7 03:17:08 EST 2008
You're right, the patch is over engineered. Robert pointed me to a much
nicer solution which I will implement and post for review (hopefully in
the coming days).
BTW: Was my mail tagged as spam by your local system/server? If so,
could you send me the headers/spam-report in a private mail? Thanks!
On Mon, 2008-01-07 at 01:04 +0100, Andreas Nahr wrote:
> Is there any specific reason for the patch?
> My assumption would be that your patch has a *much* higher memory overhead
> AND is probably considerably slower than the current implementation.
> Also I personally find the original code simpler than your code (despite
> being a little bit longer - this is probably also only true for source lines
> but not for generated IL bytes).
> The changes in GeneratePrimitiveExpression are probably ok (saves the
> > -----Ursprüngliche Nachricht-----
> > Von: mono-devel-list-bounces at lists.ximian.com
> > [mailto:mono-devel-list-bounces at lists.ximian.com] Im Auftrag
> > von Juraj Skripsky
> > Gesendet: Sonntag, 6. Januar 2008 22:30
> > An: mono-devel-list at lists.ximian.com
> > Betreff: [SPAM] [Mono-dev] [PATCH] Simplifying/optimizing
> > CodeGenerator.cs
> > Hi,
> > Attached you'll find a patch for CodeGenerator.cs (in
> > System.CodeDom.Compiler). It simplifies two methods
> > considerably and might also bring a small performance
> > improvement (perf. tests pending).
> > All unit tests pass. May I commit?
> > - Juraj
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
More information about the Mono-devel-list