[Mono-dev] [PATCH] Uri.IsWellFormedUriString should not throw an exception.
Miguel De Icaza
miguel at novell.com
Wed Jan 28 09:28:04 EST 2009
> 1) MonoTests.System.UriTest3.IsWellFormedUriString_BadUriKind :
> System.ArgumentException was expected
It seems that all we have to do is make sure that we do validate the
UriKind value that is passed to IsWellFormedUriString.
This test in particular passes a value that is out of range (an
invalid UriKind), so the new patch should just make sure that it is
validating and throwing an exception on the second parameter to
> On Sat, Jan 24, 2009 at 9:06 PM, Miguel De Icaza <miguel at novell.com>
>> Hello Bill,
>> Any chance of redoing the code as suggested by Robert?
>> If so, it is OK to get this on the 2.4 branch.
>> On Jan 21, 2009, at 12:01 PM, Bill Holmes wrote:
>>> The attached patch fixes the attached test.cs.
>>> Uri.IsWellFormedUriString calls the .ctor which throws an exception.
>>> The .ctor throwing the exception is expected behavior,
>>> IsWellFormedUriString throwing is not expected.
>>> I would also like to apply this to the 2.4 branch.
>>> 2009-01-21 Bill Holmes <billholmes54 at gmail.com>
>>> * Uri.cs (IsWellFormedUriString): Changing
>>> to not throw an exception but return false instead.
>>> Contributed under MIT/X11 license.
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
More information about the Mono-devel-list