[Mono-dev] [PATCH] fixes for /mono/mono/metadata/*
kumpera at gmail.com
Wed Sep 2 15:14:16 EDT 2009
On Wed, Sep 2, 2009 at 3:53 PM, Sebastien Pouliot <
sebastien.pouliot at gmail.com> wrote:
> On Wed, 2009-09-02 at 15:50 -0300, Rodrigo Kumpera wrote:
> > Changelog:
> > @@ -25,6 +36,7 @@
> > calculating interface offsets instead of the number of methods.
> > This way we
> > avoid bubles on the layout.
> > +>>>>>>> .r141154
> > Some conflict dirt slipped in.
> > the icall.c change is superfluous, it will never be null and this is
> > dead code I forgot to remove.
> Ok. I wondered if the null check was missing (before the loop) or if the
> null check inside the loop was dead-code.
Yes, the check is dead-code, klass is never assigned so if tb was NULL we
would get a crash
But, actually, the whole function is dead code, I only did not remove it
because my SRE work is not
complete and I might have to revert the managed changes to use the icall
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mono-devel-list