[Mono-dev] GroupBy Bug (Bug 601101)
alan.mcgovern at gmail.com
Thu Apr 29 17:32:44 EDT 2010
More than 50% of your patch is whitespace noise which makes it hard to
see what exactly it is you're fixing. Could you submit a patch without
all the extra whitespace changes?
Secondly, I'd personally view any code which relies on the element
ordering in a dictionary as being a bug and should be fixed.
As for the actual patch, I have no comments ;)
On 29 Apr 2010, at 22:18, Richard Kiene <richard.kiene at logos.com> wrote:
> I have filed Bug 601101 https://bugzilla.novell.com/show_bug.cgi?id=601101
> for this issue. In addition; I have attached a patch which resolves
> the issue. That said, I'm not really sure this patch is the most
> desirable way to fix the bug. If you would like to use the patch I
> release it under the MIT/X11 License.
> Also worth noting is that a Dictionary is used to create the groups,
> but Dictionary as defined by MSDN does not preserve element
> ordering. It appears that the mono implementation of Dictionary does
> and that is why it is used, is this correct?
> Richard Kiene
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mono-devel-list