[Mono-dev] [PATCH] Add missing DateTimeOffset operators to XElement
tagdev at gmail.com
Tue Jan 12 15:25:20 EST 2010
I'm glad you made it through the obstacle course in one piece, Atsushi!
Sidestepping that tricky UIntXX case seems reasonable. What's the chance of
a backport to the 2.6 branch?
From: Atsushi Eno [mailto:atsushieno at veritas-vos-liberabit.com]
Sent: 12 January 2010 3:56 AM
To: Tiaan Geldenhuys
Cc: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] [PATCH] Add missing DateTimeOffset operators to
They are all fixed in svn trunk, except the case that casts to UIntXX
instead of OverflowException, which I believe is not possible due to
.NET's call to internal members in corlib (commented as r149388).
Man, I'm exhausted to fix those extensive tests ;-) Thanks again for the
On 2010/01/12 9:00, Atsushi Eno wrote:
> Oh, those are nice tests. Thanks for writing them :-)
> I'll examine the failing tests and will fix identified bugs.
> Atsushi Eno
> Tiaan Geldenhuys wrote:
>> Thanks, Atsushi. Fair enough, see the attachment for the enhanced tests
>> that you can also apply to the trunk; the test for my earlier patch is
>> simply whether the enhanced code can compile under Mono. However, once
>> compiled and running, the extra tests also highlight numerous
>> between the behavior of Mono and MS .NET when using the casting operators
>> XElement (all the new CastXxx tests pass under .NET, while many fail
>> Mono). It seems that the underlying XmlConvert class may cause some of
>> problems. Since I provided the welcomed tests, would you mind logging
>> bugs or fixing them? ;-)
>> -----Original Message-----
>> From: Atsushi Eno [mailto:atsushieno at veritas-vos-liberabit.com]
>> Sent: 09 January 2010 3:51 AM
>> To: Tiaan Geldenhuys
>> Cc: mono-devel-list at lists.ximian.com
>> Subject: Re: [Mono-dev] [PATCH] Add missing DateTimeOffset operators to
>> Thanks, I'm going to apply the patch. (Patches with tests are more
>> welcomed ;-)
>> Atsushi Eno
>> On 2010/01/09 13:04, Tiaan Geldenhuys wrote:
>>> This patch adds two of the newer DateTimeOffset operators that are
>>> still missing on the System.Xml.Linq.XElement class.
>>> Please commit.
>>> Mono-devel-list mailing list
>>> Mono-devel-list at lists.ximian.com
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
More information about the Mono-devel-list