[Mono-dev] Proposed Patch - Google Native Client
elijahtaylor at google.com
Fri Jul 2 12:43:36 EDT 2010
Great, glad to hear I made the right choices in those type changes. Thanks
for the update.
I was hoping for a little more feedback on the x86 codegen changes,
particularly from anyone with expertise in the code generation aspects of
mono. There's no rush on this, but it would be nice to have our changes
incorporated in the mono tree, particularly so external developers could
make use of this, and any future patches can hopefully be a bit smaller.
On Fri, Jul 2, 2010 at 7:42 AM, Zoltan Varga <vargaz at gmail.com> wrote:
>> We also had to modify some code that doesn't fall under either of the
>> above defines. Most of these changes revolved around type safety. The
>> modified version of gcc we use to compile Native Client modules is more
>> strict about types, and it caught what look like legitimate issues with the
>> Mono codebase. The largest issue in terms of number of errors was the use
>> of mono_bool and gboolean interchangeably between declaration and definition
>> of many functions. gboolean is defined as an "int" but mono_bool is defined
>> as int32_t. Other type issues are listed directly below. Feedback is
>> appreciated on these changes because of our unfamiliarity with this code,
>> but I modified these in the way that seemed most "right" at the time.
>> mono/metadata/decimal.h:47 mono_decimal2string int -> gint32
>> mono/metadata/filewatcher.h:28 gboolean -> int
>> mono/metadata/filewatcher.c:158 int32 -> gint32
>> mono/metadata/threads-type.h:64 int -> gint32
>> mono/mini/mini.h:1546 gboolean sort_end -> int sort_type
>> mono/mini/mini.h:1733 gboolean fp -> int bank
> These changes look ok, and are now in SVN.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mono-devel-list