gregoryyoung1 at gmail.com
Wed Jul 25 11:17:43 UTC 2012
Yuriy will reply with more details but by just making Take return
Creator() and nooping release many of our issues have gone away
(including visible issues with concurrentstack). From what I have seen
we also saw massive performance gains.
On Wed, Jul 25, 2012 at 6:54 AM, Greg Young <gregoryyoung1 at gmail.com> wrote:
> We have had some moving forward in our mono stability issues. I
> figured I would start up a chat here about one place that seems to be
> causing many problems.
> I am not really sure the code here is actually thread safe... Maybe it
> doesn't need to be for some reason?
> We have added volatiles for add/remove index (yuriy pointed out that
> threads were often stuck at line 86) but even with that im still not
> sure its actually threadsafe. There are some weird edge conditions
> that seem to be here (like if CompareExchange fails 3 times it will
> just never set the remove index and continue on).
> Somebody has obviously spent a lot of time thinking about this code
> and optimizing it. I want to make sure we get the full "why" behind
> things so we dont a) waste time b) introduce issues.
> Le doute n'est pas une condition agréable, mais la certitude est absurde.
Le doute n'est pas une condition agréable, mais la certitude est absurde.
More information about the Mono-devel-list