[Mono-dev] If you accept pull requests on Mono's github
Miguel de Icaza
miguel at xamarin.com
Sat Jan 3 14:14:26 UTC 2015
If you are accepting pull requests on Mono's github, please request that
pull requests that were iterated multiple-times have their multiple commits
squashed into one.
Otherwise Mono ends up merging code that does things like:
- Commit 1:
Implement a feature + reformatted entire file
- Commit 2:
Fix bug in first feature
- Commit 3:
Undo all the format changes
>From a git history perspective, we managed to make the history more
difficult to read for most of the file, not once (from commit 1), but twice
(commit 1 and 2).
So before you merge a patch from the community, please make sure that
either the contributor squashes all their commits into one, or you merge
the commit into one manually and apply the patch.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mono-devel-list