[Gtk-sharp-list] Patch for gdk/Pixbuf.custom
Wed, 27 Aug 2003 21:40:37 -0500
On Wed, 2003-08-27 at 02:53, Martin Willemoes Hansen wrote:
> Umh I added a proper copyright/information header and fixed some long
> method signatures.
(This is probably going to sound like a rant, but please take it instead
as an attempt to specify best practices for patch submittal.)
You didn't "fix" any method signatures. You introduced whitespace
changes into a patch that made it much more difficult to determine what
the real changes are. Whitespace changes like this also make it more
difficult to use cvs history commands to determine when code was added
and by whom.
Please remove the whitespace changes from the patch and commit it.
Mike Kestner <firstname.lastname@example.org>