[Gtk-sharp-list] Various enhancements to GnomePrint patch
Mon, 06 Oct 2003 15:35:15 -0500
On Mon, 2003-10-06 at 05:13, Martin Willemoes Hansen wrote:
> Vups found one more bug, here is a new patch.
Thanks for the patch.
A few comments. Please try to include things in one diff. You can have
new files in the diff by doing a cvs add and using the -N option on your
cvs diff command.
Of course, lose the garbage gdk-api.xml change.
<method name="Get" cname="gnome_print_config_get">
- <return-type type="guchar*"/>
+ <return-type type="const-gchar*"/>
Did you verify that the returned string here is not owned by the
caller? If you go marking stuff const that isn't const, it's going to
- <parameter type="gint" name="flags"/>
+ <parameter type="GnomePrintDialogFlags*" name="flags"/>
You really want that '*' there? I don't know this api, but it would
seem strange for a gint to actually be a pointer to an enumerated type.
Mike Kestner <email@example.com>