[Gtk-sharp-list] PATCH: speed up treeview and managed values

John Luke jluke@users.sourceforge.net
Sun, 15 Feb 2004 02:53:27 -0500

On Sun, 2004-02-15 at 01:05, Ben Maurer wrote:
> Hello,
> The patch is at:
> http://devservices.go-mono.com/~benm/patches/gtksharp-treemodel-managedvalue.patch
> Overall, this made a noticable difference when loading a large project
> (in this case, the MCS compiler) in MonoDevelop. The time improved and
> memory was down by a few MB (according to top).

A few comments after glancing over the patch:
- I believe it is still considered appropriate to actually attach a
patch, at least so it is preserved and not lost. 
- The rest of Gtk# and GTK+ is LGPL licensed why did you submit these
with GPL headers.
- I'm not crazy about special casing certain things to C code solely for
performance unless it is very necessary.  Hopefully you looked into the
future maintainability, considered the NodeStore implementation, and GTK
2.4 changes.